Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: blackify #6146

Merged
merged 5 commits into from
Feb 29, 2024
Merged

chore: blackify #6146

merged 5 commits into from
Feb 29, 2024

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Feb 29, 2024

Goals:

  • resolves #ISSUE-NUMBER

  • ...

  • ...

  • ...

  • ...

  • check and update documentation. See guide and ask the team.

@JoanFM JoanFM requested a review from hanxiao as a code owner February 29, 2024 13:13
@github-actions GitHub Actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions github-actions bot added area/core This issue/PR affects the core codebase area/entrypoint This issue/PR affects the entrypoint codebase area/helper This issue/PR affects the helper functionality area/network This issue/PR affects network functionality area/testing This issue/PR affects testing component/client component/jaml component/proto component/resource component/type labels Feb 29, 2024
@github-actions GitHub Actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

1 similar comment
@github-actions GitHub Actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@JoanFM JoanFM closed this Feb 29, 2024
@JoanFM JoanFM reopened this Feb 29, 2024
@github-actions GitHub Actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@codecov Codecov
Copy link

codecov bot commented Feb 29, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 13.87387% with 478 lines in your changes are missing coverage. Please review.

Project coverage is 75.05%. Comparing base (8a58dfa) to head (c038df8).
Report is 1 commits behind head on master.

Files Patch % Lines
jina/proto/docarray_v1/pb2/jina_pb2.py 0.00% 94 Missing ⚠️
jina/proto/docarray_v2/pb2/jina_pb2.py 0.00% 94 Missing ⚠️
jina/proto/docarray_v2/pb/jina_pb2.py 0.00% 72 Missing ⚠️
jina/proto/docarray_v1/pb/jina_pb2.py 1.38% 71 Missing ⚠️
jina/proto/docarray_v1/pb2/jina_pb2_grpc.py 0.00% 22 Missing ⚠️
jina/proto/docarray_v2/pb/jina_pb2_grpc.py 0.00% 22 Missing ⚠️
jina/proto/docarray_v2/pb2/jina_pb2_grpc.py 0.00% 22 Missing ⚠️
...ina/serve/consensus/add_voter/pb2/add_voter_pb2.py 0.00% 16 Missing ⚠️
jina/serve/consensus/add_voter/pb/add_voter_pb2.py 0.00% 12 Missing ⚠️
jina/proto/docarray_v1/pb/jina_pb2_grpc.py 50.00% 11 Missing ⚠️
... and 13 more
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6146      +/-   ##
==========================================
+ Coverage   75.04%   75.05%   +0.01%     
==========================================
  Files         152      152              
  Lines       14095    14093       -2     
==========================================
  Hits        10577    10577              
+ Misses       3518     3516       -2
Flag Coverage Δ
jina 75.05% <13.87%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@JoanFM JoanFM merged commit d3aecc0 into master Feb 29, 2024
130 of 131 checks passed
@JoanFM JoanFM deleted the chore-blackify branch February 29, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanxiao hanxiao Awaiting requested review from hanxiao hanxiao is a code owner

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/entrypoint This issue/PR affects the entrypoint codebase area/helper This issue/PR affects the helper functionality area/network This issue/PR affects network functionality area/testing This issue/PR affects testing component/client component/jaml component/proto component/resource component/type size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoanFM @jina-bot